Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(legend): improve tooltip wording #2439

Merged
merged 11 commits into from
Jun 3, 2024

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented May 21, 2024

Summary

The legend title tooltip wording has been improved to be clearer.
Screenshot 2024-05-21 at 15 43 57
Screenshot 2024-05-21 at 15 43 49
Screenshot 2024-05-21 at 15 43 40

Details

Improved the wording as described in #2438

Issue

closes #2438

@dej611 dej611 added :legend Legend related issue :accessibility Accessibility related issue :xy Bar/Line/Area chart related labels May 21, 2024
Copy link
Collaborator

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, just mentioned 2 ideas I think would improve the appearance.

cc: @gvnmagni

packages/charts/src/components/legend/label.tsx Outdated Show resolved Hide resolved
packages/charts/src/components/legend/label.tsx Outdated Show resolved Hide resolved
packages/charts/src/components/legend/label.tsx Outdated Show resolved Hide resolved
packages/charts/src/components/legend/label.tsx Outdated Show resolved Hide resolved
packages/charts/src/components/legend/label.tsx Outdated Show resolved Hide resolved
packages/charts/src/components/legend/label.tsx Outdated Show resolved Hide resolved
packages/charts/src/components/legend/label.tsx Outdated Show resolved Hide resolved
@nickofthyme nickofthyme merged commit 27c04f4 into elastic:main Jun 3, 2024
14 checks passed
nickofthyme pushed a commit that referenced this pull request Jun 4, 2024
# [65.2.0](v65.1.0...v65.2.0) (2024-06-04)

### Bug Fixes

* **deps:** update dependency @elastic/eui to ^94.5.2 ([#2450](#2450)) ([26b425c](26b425c))
* **deps:** update dependency @elastic/eui to ^94.6.0 ([#2454](#2454)) ([6759469](6759469))
* **deps:** update dependency @playwright/test to ^1.44.1 ([#2451](#2451)) ([158b4c2](158b4c2))
* **deps:** update dependency json-schema-to-typescript to v14.0.5 ([#2452](#2452)) ([7947e17](7947e17))
* **metric:** chart not rendered when the trend is empty ([#2447](#2447)) ([6042cc8](6042cc8))
* **sunburst:** rendering for full sections ([#2457](#2457)) ([58c2721](58c2721))

### Features

* **legend:** improve tooltip wording ([#2439](#2439)) ([27c04f4](27c04f4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:accessibility Accessibility related issue :legend Legend related issue :xy Bar/Line/Area chart related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Legend] Instructions descriptions in tooltip
4 participants