Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xy): single point visibility #2557

Merged

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Oct 23, 2024

Summary

Fixes a regression where a single point series where not anymore visible with the current theme and changes applied via #2525

Details

The definition of "connected line" was incomplete and didn't consider a single point series.
This was fixed and also tests were added.

Issues

fix from the elastic-chart side elastic/kibana#197347

Checklist

  • The proper chart type label has been added (e.g. :xy, :partition)
  • The proper feature labels have been added (e.g. :interactions, :axis)
  • Unit tests have been added or updated to match the most common scenarios
  • The proper documentation and/or storybook story has been added or updated

@markov00 markov00 added bug Something isn't working regression :xy Bar/Line/Area chart related :rendering Rendering related issues labels Oct 23, 2024
@markov00
Copy link
Member Author

buildkite update screenshots

@markov00 markov00 marked this pull request as ready for review October 23, 2024 12:46
Copy link
Collaborator

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, fixes issue.

@markov00 markov00 merged commit e16c902 into elastic:main Oct 24, 2024
14 checks passed
@markov00 markov00 deleted the 2024_10_23-fix_single_point_visibility branch October 24, 2024 06:52
nickofthyme pushed a commit that referenced this pull request Oct 24, 2024
## [68.0.2](v68.0.1...v68.0.2) (2024-10-24)

### Bug Fixes

* **xy:** single point visibility ([#2557](#2557)) ([e16c902](e16c902))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression :rendering Rendering related issues :xy Bar/Line/Area chart related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants