Skip to content

Commit

Permalink
WriteEvent Option on ChannelOptionBase is never called (#74)
Browse files Browse the repository at this point in the history
It is set in several ecs-dotnet projects but its never called here.

IElasticsearchEventWriter<TEvent> is the right mechanism to override event serialization.
  • Loading branch information
Mpdreamz authored Oct 3, 2024
1 parent 2037c14 commit db36a56
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions src/Elastic.Channels/ChannelOptionsBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@

using System;
using System.Collections.Generic;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
using Elastic.Channels.Buffers;
using Elastic.Channels.Diagnostics;

Expand All @@ -32,11 +30,6 @@ public abstract class ChannelOptionsBase<TEvent, TResponse> : IChannelCallbacks<
/// <summary> Provide an external cancellation token </summary>
public CancellationToken? CancellationToken { get; set; }

/// <summary>
/// Optionally provides a custom write implementation to a channel. Concrete channel implementations are not required to adhere to this config
/// </summary>
public Func<Stream, CancellationToken, TEvent, Task>? WriteEvent { get; set; } = null;

/// <inheritdoc cref="IChannelCallbacks{TEvent,TResponse}.ExportExceptionCallback"/>
public Action<Exception>? ExportExceptionCallback { get; set; }

Expand Down

0 comments on commit db36a56

Please sign in to comment.