Improve configuration story #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
requested changes
May 2, 2024
|
@Mpdreamz In my refactoring I'd lost the logic to fallback to the logging section. I've reimplemented that in the latest commit and updated the `LoggingEventListener" so it uses the options value now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the configuration implementation to allow loading of options from
IConfigurationas well as loading from environment variables. The primary implementation for review is inElasticOpenTelemetryOptions. For most other changes, just update to use this and apply the configuration.Adds documentation for the current configuration options.
Adds tests around the loading of configuration.
Closes #62
Closes #61
Closes #52
This relates to #83 as we add configuration to support this scenario.