chore: add NOTICE files and check that deps have known licenses #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'npm run lint' will now ensure that added deps (excluding devDeps) only use known licenses (gen-notice.sh --lint). As well, if/when we make distributions of these packages (e.g. a Docker image, whatever) then this gen-notice.sh can be used to inline all the included deps' license files into the NOTICE file. Refs: #45
david-luna
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
The majority of this file is a node script executed with - e option and it's called from a noms script. Do you think it's possible to have it as a .js file?
There was a problem hiding this comment.
Possible, yes. However, the script is derived from the same one we use in elastic-apm-node.git. I'm not sure we'll ever or much edit this file after this initial commit, so I'm not sure re-writing it has value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'npm run lint' will now ensure that added deps (excluding devDeps) only
use known licenses (gen-notice.sh --lint). As well, if/when we make
distributions of these packages (e.g. a Docker image, whatever) then
this gen-notice.sh can be used to inline all the included deps'
license files into the NOTICE file.
Refs: #45