Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improved OpenAI + EDOT Node.js examples #512

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

trentm
Copy link
Member

@trentm trentm commented Jan 7, 2025

This replaces the single examples/openai-chat.js with a examples/openai/ dir. That dir is self-contained (doesn't have a dep on a relative directory) and has both a chat and embeddings GenAI example.

@trentm trentm self-assigned this Jan 7, 2025
@trentm
Copy link
Member Author

trentm commented Jan 7, 2025

@codefromthecrypt In the embeddings example I see this lint warning:

The left-hand side of an arithmetic operation must be of type 'any', 'number', 'bigint' or an enum type. ts(2362)

Screenshot 2025-01-07 at 9 58 15 AM

Copy link

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool thanks for the help on this. feel free to change anything to satisfy linters.

@codefromthecrypt codefromthecrypt merged commit 78bcc5b into main Jan 8, 2025
3 checks passed
@codefromthecrypt codefromthecrypt deleted the trentm/improve-openai-example branch January 8, 2025 07:26
@codefromthecrypt
Copy link

merged to unblock other things, feel free to polish up the example later due to any reason including linting. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants