Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: stop calling deprecated grpcServer.start #71

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

trentm
Copy link
Member

@trentm trentm commented Feb 12, 2024

As of @grpc/grpc-js 1.10.0 '.start()' is deprecated and a no-op.

Refs: #60
Refs: https://github.com/grpc/proposal/blob/master/L107-node-noop-start.md


Before this change mockotlpserver would show a deprecation warning on startup:

% node --trace-deprecation lib/cli.js
{"name":"mockotlpserver","level":30,"msg":"OTLP/HTTP listening at http://127.0.0.1:4318/","time":"2024-02-12T17:33:35.493Z"}
{"name":"mockotlpserver","level":30,"msg":"OTLP/HTTP listening at http://localhost:4317/","time":"2024-02-12T17:33:35.500Z"}
(node:72369) DeprecationWarning: Calling start() is no longer necessary. It can be safely omitted.
    at /Users/trentm/el/elastic-otel-node2/packages/mockotlpserver/lib/grpc.js:97:42
    at /Users/trentm/el/elastic-otel-node2/node_modules/@grpc/grpc-js/build/src/server.js:567:25
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
{"name":"mockotlpserver","level":30,"msg":"UI listening at http://127.0.0.1:8080/","time":"2024-02-12T17:33:35.502Z"}

As of @grpc/grpc-js 1.10.0 '.start()' is deprecated and a no-op.

Refs: #60
Refs: https://github.com/grpc/proposal/blob/master/L107-node-noop-start.md
@trentm trentm self-assigned this Feb 12, 2024
@trentm trentm merged commit 90b725f into main Feb 12, 2024
11 checks passed
@trentm trentm deleted the trentm/grpc-start-deprecation branch February 12, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants