Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the point field #1959

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Add support for the point field #1959

merged 2 commits into from
Jan 7, 2025

Conversation

Telomeraz
Copy link
Contributor

Closes #1958

@miguelgrinberg miguelgrinberg merged commit c0aa52a into elastic:main Jan 7, 2025
18 checks passed
@miguelgrinberg miguelgrinberg mentioned this pull request Jan 7, 2025
Merged
@miguelgrinberg miguelgrinberg added the backport 8.x Backport to 8.x label Jan 7, 2025
github-actions bot pushed a commit that referenced this pull request Jan 7, 2025
@Telomeraz @github-actions
Add support for the point and shape fields (#1959)
90b3789 
* Add support for the point field

* add shape field, remove unnecessary point examples

---------

Co-authored-by: Miguel Grinberg <[email protected]>
(cherry picked from commit c0aa52a)
@github-actions github-actions bot mentioned this pull request Jan 7, 2025
Merged
miguelgrinberg added a commit that referenced this pull request Jan 7, 2025
@github-actions @Telomeraz @miguelgrinberg
[Backport 8.x] Add support for the point field (#1963)
9011e0c 
* Add support for the point and shape fields (#1959)

* Add support for the point field

* add shape field, remove unnecessary point examples

---------

Co-authored-by: Miguel Grinberg <[email protected]>
(cherry picked from commit c0aa52a)

* Add shape declaration (#1962)

* Add support for the point field

* add shape field, remove unnecessary point examples

* add missing Shape declaration

---------

Co-authored-by: Hüseyin Emre Armağan <[email protected]>

---------

Co-authored-by: Hüseyin Emre Armağan <[email protected]>
Co-authored-by: Miguel Grinberg <[email protected]>
@miguelgrinberg
Copy link
Collaborator

Thanks! I added Shape to your PR, and also removed the examples that you created, because they could create confusion in the way that you used several different formats and an Any type hint. I would expect most application would stick to a single format and then use an appropriate type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelgrinberg miguelgrinberg miguelgrinberg approved these changes

Assignees
No one assigned
Labels
backport 8.x Backport to 8.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for "point" field type
2 participants
@Telomeraz @miguelgrinberg