-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Elasticsearch-DSL code #2736
base: main
Are you sure you want to change the base?
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
8092ab9
to
4ec2881
Compare
4ec2881
to
7b1af33
Compare
@@ -43,6 +43,8 @@ keywords = [ | |||
dynamic = ["version"] | |||
dependencies = [ | |||
"elastic-transport>=8.15.1,<9", | |||
"python-dateutil", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For what it's worth, this one makes me a bit sad, as it still pulls six to this day: https://inspector.pypi.io/project/python-dateutil/2.9.0.post0/packages/ec/57/56b9bcc3c9c6a792fcbaf139543cee77261f3651ca9da0c93f5c1221264b/python_dateutil-2.9.0.post0-py2.py3-none-any.whl/python_dateutil-2.9.0.post0.dist-info/METADATA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me see if we can drop it.
5dd57f6
to
2bde52a
Compare
2bde52a
to
3edc221
Compare
51af1c2
to
735e364
Compare
7831804
to
1d951c6
Compare
1d951c6
to
9cab9c2
Compare
@pquentin The builds are currently not generating code coverage data, and I haven't been able to figure out why. And I get coverage data when I run the tests locally. I'll continue looking for this, but if you have any ideas why this is happening let me know. Other than this the PR is ready for a review. |
This change adds the Elasticsearch-DSL code. Note that the documentation will be merged in a separate PR.
elasticsearch_dsl
package, except that its root is nowelasticsearch.dsl
. Users can replace the_
with a.
in all imports.https://
Elasticsearch endpoints, since that is what we are using in integration test runs.run-unasync-dsl.py
script. We can consider merging the two.generator.py
script that generates the query, aggregation and response source files was moved to this project asgenerator-dsl.py
, along with its Jinja templates. We can consider moving this to the Python client generator project.