Return "serverless" for node ID in serverless

Changing the approach for node ID to still return the field but always set to "serverless" in serverless. This avoids causing problems for users who want to use the stateful client with serverless.
elastic · Jul 26, 2023 · 26e1b66 · 26e1b66
1 parent 0b34fba
commit 26e1b66
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 7 deletions.
diff --git a/specification/ml/open_job/MlOpenJobResponse.ts b/specification/ml/open_job/MlOpenJobResponse.ts
@@ -23,7 +23,8 @@ export class Response {
   body: {
     opened: boolean
     /**
-     * @availability stack
+     * The ID of the node that the job was started on. In serverless this will be the "serverless".
+     * If the job is allowed to open lazily and has not yet been assigned to a node, this value is an empty string.
      */
     node: NodeId
   }

diff --git a/specification/ml/start_data_frame_analytics/MlStartDataFrameAnalyticsResponse.ts b/specification/ml/start_data_frame_analytics/MlStartDataFrameAnalyticsResponse.ts
@@ -24,7 +24,10 @@ export class Response {
     acknowledged: boolean
     /**
      * The ID of the node that the job was started on. If the job is allowed to open lazily and has not yet been assigned to a node, this value is an empty string.
-     * @availability stack
+     * The node ID of the node the job has been assigned to, or
+     * an empty string if it hasn't been assigned to a node. In
+     * serverless if the job has been assigned to run then the
+     * node ID will be "serverless".
      */
     node: NodeId
   }

diff --git a/specification/ml/start_datafeed/MlStartDatafeedResponse.ts b/specification/ml/start_datafeed/MlStartDatafeedResponse.ts
@@ -22,9 +22,8 @@ import { NodeIds } from '@_types/common'
 export class Response {
   body: {
     /**
-     * The ID of the node that the datafeed was started on. If the datafeed is allowed to open lazily and has not yet
-     * been assigned to a node, this value is an empty string.
-     * @availability stack
+     * The ID of the node that the job was started on. In serverless this will be the "serverless".
+     * If the job is allowed to open lazily and has not yet been assigned to a node, this value is an empty string.
      */
     node: NodeIds
     /**

diff --git a/specification/ml/upgrade_job_snapshot/MlUpgradeJobSnapshotResponse.ts b/specification/ml/upgrade_job_snapshot/MlUpgradeJobSnapshotResponse.ts
@@ -22,8 +22,7 @@ import { NodeId } from '@_types/common'
 export class Response {
   body: {
     /**
-     * The ID of the assigned node for the upgrade task if it is still running.
-     * @availability stack
+     * The ID of the node that the upgrade task was started on if it is still running. In serverless this will be the "serverless".
      */
     node: NodeId
     /** When true, this means the task is complete. When false, it is still running. */