PR feedback

elastic · Oct 18, 2024 · 3cda8d4 · 3cda8d4
1 parent d80bd2b
commit 3cda8d4
Show file tree

Hide file tree

Showing 5 changed files with 129 additions and 45 deletions.
diff --git a/output/schema/schema.json b/output/schema/schema.json
diff --git a/output/schema/validation-errors.json b/output/schema/validation-errors.json
diff --git a/output/typescript/types.ts b/output/typescript/types.ts
diff --git a/specification/query_rules/test/QueryRulesetTestResponse.ts b/specification/query_rules/test/QueryRulesetTestResponse.ts
@@ -17,12 +17,23 @@
  * under the License.
  */
 
+import { Id } from '@_types/common'
 import { integer } from '@_types/Numeric'
-import { QueryRulesetMatchedRule } from './types'
 
 export class Response {
   body: {
     total_matched_rules: integer
     matched_rules: QueryRulesetMatchedRule[]
   }
 }
+
+export class QueryRulesetMatchedRule {
+  /**
+   * Ruleset unique identifier
+   */
+  ruleset_id: Id
+  /**
+   * Rule unique identifier within that ruleset
+   */
+  rule_id: Id
+}
diff --git a/specification/query_rules/test/types.ts b/specification/query_rules/test/types.ts