Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

max_score and _score are required (and can be null) #1144

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

max_score and _score are required (and can be null) #1144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c32fdba
max_score and _score are required (and can be null)
swallez Dec 16, 2021
9f5f35c
Better with "make contrib"
swallez Dec 16, 2021
904847f
Merge remote-tracking branch 'origin/main' into make-score-required
pquentin Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions output/schema/schema.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions output/typescript/types.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions specification/_global/search/_types/hits.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export class Hit<TDocument> {
* on a search request. Otherwise the field is always present on hits.
*/
_id?: Id
_score?: double | null
_score: double | null
_explanation?: Explanation
fields?: Dictionary<string, UserDefinedValue>
highlight?: Dictionary<string, string[]>
Expand All @@ -68,7 +68,7 @@ export class HitsMetadata<T> {
total?: TotalHits | long
hits: Hit<T>[]

max_score?: double | null
max_score: double | null
}

export class HitMetadata<TDocument> {
Expand Down
Loading