Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serverless annotation to search mvt #2186

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Add serverless annotation to search mvt #2186

merged 2 commits into from
Aug 21, 2023

Conversation

iverase
Copy link
Contributor

@iverase iverase commented Jul 17, 2023

The search mvt API is a public API in serverless, therefore adding corresponding annotation.

@@ -32,7 +32,8 @@ import { TrackHits } from '@global/search/_types/hits'

/**
* @rest_spec_name search_mvt
* @availability stack since=7.15.0 stability=experimental
* @availability stack since=7.15.0 stability=stable
Copy link
Contributor Author

@iverase iverase Jul 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API has been stable since 7.16

Copy link

@craigtaverner craigtaverner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems very important!

Copy link
Member

@swallez swallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The "Validate APIs" checks fails as it doesn't work with forks, but the PR changes are correct.

@swallez swallez merged commit 1271df5 into elastic:main Aug 21, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants