Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Adds descriptions to Logstash APIs #2240

Merged
merged 4 commits into from
Aug 16, 2023
Merged

[DOCS] Adds descriptions to Logstash APIs #2240

merged 4 commits into from
Aug 16, 2023

Conversation

szabosteve
Copy link
Contributor

Overview

Related to #964.

Adds descriptions to Logstash API properties. Source of info: https://www.elastic.co/guide/en/elasticsearch/reference/master/logstash-apis.html

@szabosteve szabosteve mentioned this pull request Aug 16, 2023
Closed
64 tasks
abdonpijpelink
abdonpijpelink approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@abdonpijpelink abdonpijpelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've left a suggestion to add descriptions for the pipeline settings. Non-blocking though.

specification/logstash/_types/Pipeline.ts Show resolved Hide resolved
@github-actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
logstash.delete_pipeline ⚪ Missing test Missing test
logstash.get_pipeline ⚪ Missing test Missing test
logstash.put_pipeline ⚪ Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@szabosteve szabosteve merged commit bcb1ecd into main Aug 16, 2023
5 checks passed
@szabosteve szabosteve deleted the szabosteve/logstash branch August 16, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdonpijpelink abdonpijpelink abdonpijpelink approved these changes

Assignees
No one assigned
Labels
specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szabosteve @abdonpijpelink