Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add descriptions for suggesters #2246

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Conversation

abdonpijpelink
Copy link
Contributor

Relates to #964.

Adds descriptions for the suggesters. Descriptions were sourced from https://www.elastic.co/guide/en/elasticsearch/reference/current/search-suggesters.html

Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one suggestion!

specification/_global/search/_types/suggester.ts Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
search 🔴 1519/1538 1519/1520

You can validate this API yourself by using the make validate target.

@abdonpijpelink abdonpijpelink merged commit a2e0bd9 into main Aug 24, 2023
5 checks passed
@abdonpijpelink abdonpijpelink deleted the descriptions-suggesters branch August 24, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants