Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adds description to Rollup APIs #2253

Merged
merged 3 commits into from
Aug 28, 2023
Merged

[DOCS] Adds description to Rollup APIs #2253

merged 3 commits into from
Aug 28, 2023

Conversation

szabosteve
Copy link
Contributor

Overview

Related to #964.

Adds descriptions to Rollup API properties. Source of info:

@szabosteve szabosteve marked this pull request as ready for review August 28, 2023 15:32
Copy link
Contributor

@abdonpijpelink abdonpijpelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a minor suggestion.

specification/rollup/_types/Groupings.ts Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
rollup.delete_job 🟢 3/3 3/3
rollup.get_jobs 🟢 11/11 11/11
rollup.get_rollup_caps 🟢 3/3 3/3
rollup.get_rollup_index_caps 🟢 7/7 7/7
rollup.put_job 🟢 23/23 23/23
rollup.rollup_search 🟢 18/18 18/18
rollup.start_job 🟢 8/8 8/8
rollup.stop_job 🟢 5/5 5/5

You can validate these APIs yourself by using the make validate target.

@szabosteve szabosteve merged commit f7a647c into main Aug 28, 2023
5 checks passed
@szabosteve szabosteve deleted the szabosteve/rollups branch August 28, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants