Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand snapshot repository types #2255

Merged
merged 13 commits into from
Mar 6, 2024
Merged

Expand snapshot repository types #2255

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e8a8ea5
Expand snapshot repository types
JoshMock Aug 28, 2023
66b15ad
Formatting cleanup
JoshMock Aug 28, 2023
95afeba
Merge branch 'main' into snapshot-repos
JoshMock Aug 30, 2023
ac703f9
Add variants annotations
JoshMock Aug 30, 2023
f955014
Add a Repository base class for shared attributes
JoshMock Aug 30, 2023
03ded5c
Add type property to repo settings classes
JoshMock Aug 31, 2023
b927c24
Merge branch 'main' into snapshot-repos
JoshMock Feb 29, 2024
48e1d2a
Drop unused repository settings union type
JoshMock Feb 29, 2024
ed879d8
Merge branch 'main' into snapshot-repos
JoshMock Mar 5, 2024
bb1c61e
Consider codegen_name when checking property name uniqueness
swallez Mar 6, 2024
428feaf
Remove "type" attribute in RepositorySettings
swallez Mar 6, 2024
e4d8e32
remove read_only, only readonly is used on the server
swallez Mar 6, 2024
1600edb
make linter happy
swallez Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions compiler/src/model/build-model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,14 +270,14 @@ function compileClassOrInterfaceDeclaration (declaration: ClassDeclaration | Int
const queryType = type.query.find(property => property != null && property.name === part.name) as model.Property
if (!deepEqual(queryType.type, part.type)) {
assert(pathMember as Node, part.codegenName != null, `'${part.name}' already exist in the query_parameters with a different type, you should define an @codegen_name.`)
assert(pathMember as Node, !type.query.map(p => p.name).includes(part.codegenName), `The codegen_name '${part.codegenName}' already exists as parameter in query_parameters.`)
assert(pathMember as Node, !type.query.map(p => p.codegenName || p.name).includes(part.codegenName), `The codegen_name '${part.codegenName}' already exists as parameter in query_parameters.`)
}
}
if (bodyProperties.map(p => p.name).includes(part.name)) {
const bodyType = bodyProperties.find(property => property != null && property.name === part.name) as model.Property
if (!deepEqual(bodyType.type, part.type)) {
assert(pathMember as Node, part.codegenName != null, `'${part.name}' already exist in the body with a different type, you should define an @codegen_name.`)
assert(pathMember as Node, !bodyProperties.map(p => p.name).includes(part.codegenName), `The codegen_name '${part.codegenName}' already exists as parameter in body.`)
assert(pathMember as Node, !bodyProperties.map(p => p.codegenName || p.name).includes(part.codegenName), `The codegen_name '${part.codegenName}' already exists as parameter in body.`)
}
}
}
Expand All @@ -296,7 +296,7 @@ function compileClassOrInterfaceDeclaration (declaration: ClassDeclaration | Int
)
assert(
(bodyMember as PropertySignature).getJsDocs(),
!type.path.map(p => p.name).concat(type.query.map(p => p.name)).includes(tags.codegen_name),
!type.path.map(p => p.codegenName || p.name).concat(type.query.map(p => p.codegenName || p.name)).includes(tags.codegen_name),
`The codegen_name '${tags.codegen_name}' already exists as a property in the path or query.`
)
type.body = {
Expand Down
Loading
Loading