Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add downsampling spec for data stream lifecycle #2256

Closed
wants to merge 8 commits into from

Conversation

andreidan
Copy link
Contributor

This adds the specification for downsampling as part of
the data stream lifecycle.

The downsampling configuration is nullable (just like
data_retention) and itself can contain a nullable list
of downsampling rounds.

Each round consists of an after duration/timevalue field
and the downsample configuration (the fixed_interval)

@andreidan
Copy link
Contributor Author

@elastic/clients-team this build is failing with

build
Input required and not supplied: token

Can someone please advise?

Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what that build error is about, but fixing this typo will rerun the job anyway. 🙂

output/typescript/types.ts Outdated Show resolved Hide resolved
output/schema/schema.json Show resolved Hide resolved
andreidan and others added 3 commits August 29, 2023 16:53
Co-authored-by: Josh Mock <[email protected]>
Co-authored-by: Josh Mock <[email protected]>
@andreidan
Copy link
Contributor Author

Thanks @JoshMock Seems like the build is happy now

Copy link
Contributor

@gmarouli gmarouli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as discussed offline, we agreed that we should allow the client to nullify the rounds. The user can use the downsampling?: DataStreamLifecycleDownsampling to express a nullification during template composition. Apart from that 🚀

@andreidan
Copy link
Contributor Author

Superseeded by #2259

@andreidan andreidan closed this Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants