Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix body nullability #2464

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Fix body nullability #2464

merged 1 commit into from
Mar 25, 2024

Conversation

flobernd
Copy link
Member

Removes incorrect nullability marker from certain bodies.

Related to #2463

@flobernd flobernd requested review from a team as code owners March 22, 2024 15:00
@flobernd flobernd requested a review from a team March 22, 2024 15:00
@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
bulk 🟢 339/339 357/357
create 🟢 30/30 29/29
fleet.msearch ⚪ Missing test Missing test
index 🔴 835/850 852/852
indices.downsample 🟢 1/1 1/1
ml.validate_detector 🟢 2/2 2/2
monitoring.bulk 🟢 6/6 6/6
msearch 🟢 17/17 16/16
security.put_privileges 🟢 10/10 10/10

You can validate these APIs yourself by using the make validate target.

davidkyle
davidkyle approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML change LGTM thanks @flobernd

@flobernd flobernd merged commit a20d260 into main Mar 25, 2024
6 checks passed
@flobernd flobernd deleted the body-nullability branch March 25, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkyle davidkyle davidkyle approved these changes

Assignees
No one assigned
Labels
specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flobernd @davidkyle