Add unwrapping and inlining to expand-generics #2504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swallez
force-pushed
the
compiler-inline-generics
branch
from
66cec93
to
949fdb6
Compare
Anaethelion
approved these changes
May 13, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 13, 2024
* Add unwrapping and inlining to expand-generics * Make linter happy * Add unwrapping and inlining to expand-generics (Rust edition) * Update OpenAPI spec with inlined WithNullValue --------- Co-authored-by: Laurent Saint-Félix <[email protected]> (cherry picked from commit 2f1902b)
Anaethelion
pushed a commit
that referenced
this pull request
May 13, 2024
* Add unwrapping and inlining to expand-generics * Make linter happy * Add unwrapping and inlining to expand-generics (Rust edition) * Update OpenAPI spec with inlined WithNullValue --------- Co-authored-by: Laurent Saint-Félix <[email protected]> (cherry picked from commit 2f1902b) Co-authored-by: Sylvain Wallez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addition of
WithNullValueis causing issues in the generic expansion process as it creates new types for what is more a convenience notation than an actual type.This PR enhances the "expand-generics" transformation with two configurations:
foo: WithNullValue<string>to be converted tofoo: string | NullValue.foo: Stringified<integer>to be converted tofoo: integer.This PR only inlines
WithNullValue, as unwrappingStringifiedwould change what is currently being generated.