Add dangling types to the generic-less schema #2542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l-trotta
approved these changes
May 3, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 3, 2024
* add dangling types to the genericless schema * fix linting * add an explicit pass in expandInterface for missing behaviors * please the linter gods by using a const (cherry picked from commit 0f89005)
Anaethelion
added a commit
that referenced
this pull request
May 3, 2024
* add dangling types to the genericless schema * fix linting * add an explicit pass in expandInterface for missing behaviors * please the linter gods by using a const (cherry picked from commit 0f89005) Co-authored-by: Laurent Saint-Félix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parses the leftovers from the expansion which are tied to no
RequestnorResponseand adds the missing behaviors without generics to the processed schema.It allows the generic-less schema to know about:
CommonCatQueryParametersCommonQueryParametersBaseServerlessEsqlVersionBaseStatefulEsqlVersion