Attach generic type parameters to the declaring type #2619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flobernd
requested review from
JoshMock,
swallez,
Anaethelion,
l-trotta and
a team
flobernd
force-pushed
the
improve-generic-params
branch
from
ab6e89c
to
3f312fb
Compare
flobernd
force-pushed
the
improve-generic-params
branch
from
3f312fb
to
8326037
Compare
l-trotta
reviewed
Jun 18, 2024
flobernd
commented
Jun 18, 2024
compiler/src/model/json-spec.ts
Outdated
| @@ -74,5 +74,6 @@ export default function buildJsonSpec (): Map<string, JsonSpec> { | |||
| map.set(name, json[name]) | |||
| } | |||
|
|
|||
| return map | |||
| // Ensure deterministic ordering | |||
| return new Map([...map.entries()].sort()) | |||
There was a problem hiding this comment.
Maps in JS are iterated in the order of insertion. This map is created by enumerating the filesystem which causes the entries to be inserted in a different order on Linux and Windows.
flobernd
force-pushed
the
improve-generic-params
branch
from
aa4cc9f
to
d7c6b0c
Compare
swallez
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
LGTM.
@Anaethelion @JoshMock @l-trotta make sure this doesn't break anything in your respective clients. It should not, as it only changes the namespace of generic parameters, not their names.
The rationale behind this change is that it ensures global uniqueness of generic parameter names, even if their scope is limited to the enclosing type definition, which can help when processing a global type graph.
flobernd
force-pushed
the
improve-generic-params
branch
from
d7c6b0c
to
a306fdc
Compare
l-trotta
approved these changes
Jun 18, 2024
Anaethelion
approved these changes
Jun 18, 2024
JoshMock
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attach generic type parameters to the declaring type instead of the parent namespace.
This more precisely reflects the actual declaration hierarchy and allows type parameters to be uniquely identified by their FQNs.
The following definition:
caused a type parameter with the FQN
some.namespace.Tto get emitted.The same type parameter is now emitted as
some.namespace.A.Tinstead.