-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated code #2649
Remove deprecated code #2649
Conversation
85caa42
to
5a8b608
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
de9b28a
to
fbc80ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with the Ruby client generator and all good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK with Python too. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good on JS as well. I haven't updated to stop using visibility
yet, but my generator has already been broken for a couple days so I can fix this soon. 😄
Fixed in the JS generator now. 🙏 |
fbc80ee
to
704d448
Compare
Removes some deprecated fields which got replaced by
availability
a long time ago.@elastic/devtools-team Please check, if your generator correctly uses the new
availability
field instead of the legacy ones.