Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code #2649

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Remove deprecated code #2649

merged 3 commits into from
Jul 10, 2024

Conversation

flobernd
Copy link
Member

Removes some deprecated fields which got replaced by availability a long time ago.

@elastic/devtools-team Please check, if your generator correctly uses the new availability field instead of the legacy ones.

Copy link
Member

@swallez swallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@picandocodigo picandocodigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the Ruby client generator and all good 👍

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with Python too. 👍

Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good on JS as well. I haven't updated to stop using visibility yet, but my generator has already been broken for a couple days so I can fix this soon. 😄

@JoshMock
Copy link
Member

JoshMock commented Jul 1, 2024

Fixed in the JS generator now. 🙏

@flobernd flobernd merged commit 0bd7cf9 into main Jul 10, 2024
8 checks passed
@flobernd flobernd deleted the remove-deprecated-code branch July 10, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants