Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update summaries for several endpoints #2718

Merged
merged 4 commits into from
Jul 26, 2024
Merged

Conversation

shainaraskas
Copy link
Contributor

This PR adds operation summaries for the following areas, using text from the appropriate pages from the elasticsearch API reference.

  • alias
  • license
  • lifecycle
  • refresh
  • reindex
  • rollover

part of #2635

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
indices.exists_alias 🟢 38/38 38/38
indices.explain_data_lifecycle Missing test Missing test
indices.get_alias 🔴 86/86 74/86
indices.get_settings 🔴 61/61 59/61
indices.put_alias 🔴 59/59 20/59
indices.put_settings 🔴 54/57 57/57
indices.refresh 🟢 265/265 265/265
indices.rollover 🔴 26/26 1/26
indices.update_aliases 🔴 26/26 7/26
license.get 🟢 6/6 6/6
reindex 🟢 15/15 14/14

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
indices.exists_alias 🟢 38/38 38/38
indices.explain_data_lifecycle Missing test Missing test
indices.get_alias 🔴 86/86 74/86
indices.get_settings 🔴 61/61 59/61
indices.put_alias 🔴 59/59 20/59
indices.put_settings 🔴 54/57 57/57
indices.refresh 🟢 265/265 265/265
indices.rollover 🔴 26/26 1/26
indices.update_aliases 🔴 26/26 7/26
license.get 🟢 6/6 6/6
reindex 🟢 15/15 14/14

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
indices.exists_alias 🟢 38/38 38/38
indices.explain_data_lifecycle Missing test Missing test
indices.get_alias 🔴 86/86 74/86
indices.get_settings 🔴 61/61 59/61
indices.put_alias 🔴 59/59 20/59
indices.put_settings 🔴 54/57 57/57
indices.refresh 🟢 265/265 265/265
indices.rollover 🔴 26/26 1/26
indices.update_aliases 🔴 26/26 7/26
license.get 🟢 6/6 6/6
reindex 🟢 15/15 14/14

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
indices.exists_alias 🟢 38/38 38/38
indices.explain_data_lifecycle Missing test Missing test
indices.get_alias 🔴 86/86 74/86
indices.get_settings 🔴 62/62 60/62
indices.put_alias 🔴 59/59 20/59
indices.put_settings 🔴 54/57 57/57
indices.refresh 🟢 269/269 269/269
indices.rollover 🔴 26/26 1/26
indices.update_aliases 🔴 26/26 7/26
license.get 🟢 6/6 6/6
reindex 🟢 15/15 14/14

You can validate these APIs yourself by using the make validate target.

@shainaraskas shainaraskas merged commit 4c87a43 into main Jul 26, 2024
6 checks passed
@shainaraskas shainaraskas deleted the rollover-etc-summaries branch July 26, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants