Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenAPI] Edit multi search and scroll API #3053

Merged
merged 7 commits into from
Oct 23, 2024
Merged

[OpenAPI] Edit multi search and scroll API #3053

merged 7 commits into from
Oct 23, 2024

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Oct 23, 2024

Relates to #2635

This PR adds a summary and description for the multi search and scroll APIs (copied from https://www.elastic.co/guide/en/elasticsearch/reference/current/search-multi-search.html and https://www.elastic.co/guide/en/elasticsearch/reference/current/scroll-api.html).
It also changes their tags from "msearch" and "scroll" to "search" so that they're grouped with the other search APIs.

Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
msearch 🟢 17/17 16/16

You can validate this API yourself by using the make validate target.

@lcawl lcawl changed the title [OpenAPI] Edit multi search API [OpenAPI] Edit multi search and scroll API Oct 23, 2024
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
msearch 🟢 17/17 16/16
scroll 🟢 69/69 20/20

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
msearch 🟢 17/17 16/16
scroll 🟢 69/69 20/20
terms_enum 🟢 47/47 47/47

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl marked this pull request as ready for review October 23, 2024 01:43
Copy link

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
msearch 🟢 17/17 16/16
scroll 🟢 69/69 20/20
terms_enum 🟢 47/47 47/47

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl merged commit e924f04 into main Oct 23, 2024
6 checks passed
@lcawl lcawl deleted the lcawl/search-tags branch October 23, 2024 15:34
github-actions bot pushed a commit that referenced this pull request Oct 23, 2024
github-actions bot pushed a commit that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants