Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding text_similarity_reranker retriever specification #3057

Merged
merged 10 commits into from
Oct 31, 2024
Merged

Adding text_similarity_reranker retriever specification #3057

merged 10 commits into from
Oct 31, 2024
+331 −51

Conversation

pmpailis
Copy link
Contributor

Adding missing text_similarity_reranker retriever specification

@pmpailis pmpailis changed the title Adding text_similarity_rerankerretriever specification Adding text_similarity_reranker retriever specification Oct 23, 2024
@pmpailis pmpailis marked this pull request as ready for review October 23, 2024 14:33
Anaethelion
Anaethelion requested changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@Anaethelion Anaethelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I've left a code suggestion as I think a field was missing.

specification/_types/Retriever.ts Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
search 🔴 2213/2273 2254/2255

You can validate this API yourself by using the make validate target.

@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
search 🔴 2213/2273 2254/2255

You can validate this API yourself by using the make validate target.

@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
search 🔴 2213/2273 2254/2255

You can validate this API yourself by using the make validate target.

@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
search 🔴 2213/2273 2254/2255

You can validate this API yourself by using the make validate target.

@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
search 🔴 2213/2273 2254/2255

You can validate this API yourself by using the make validate target.

@pmpailis
Copy link
Contributor Author

@Anaethelion updated and added min_score to base class RetrieverBase. Run the tests locally and couldn't find something that is related to these changes, so would appreciate another look whenever you have some time :)

Anaethelion
Anaethelion approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@Anaethelion Anaethelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pmpailis pmpailis merged commit d786091 into main Oct 31, 2024
6 checks passed
@pmpailis pmpailis deleted the updating_retrievers_specification_for_ga branch October 31, 2024 13:38
github-actions bot pushed a commit that referenced this pull request Oct 31, 2024
@pmpailis @github-actions
Adding text_similarity_reranker retriever specification (#3057)
666977d 
(cherry picked from commit d786091)
@github-actions github-actions bot mentioned this pull request Oct 31, 2024
Open
github-actions bot pushed a commit that referenced this pull request Oct 31, 2024
@pmpailis @github-actions
Adding text_similarity_reranker retriever specification (#3057)
09ab29c 
(cherry picked from commit d786091)
@github-actions github-actions bot mentioned this pull request Oct 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anaethelion Anaethelion Anaethelion approved these changes

Assignees
No one assigned
Labels
backport 8.x backport 8.16 specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmpailis @Anaethelion