-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cross cluster security APIs #3070
base: main
Are you sure you want to change the base?
Conversation
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
1 similar comment
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
specification/security/create_cross_cluster_api_key/CreateCrossClusterApiKeyResponse.ts
Outdated
Show resolved
Hide resolved
…sClusterApiKeyResponse.ts Co-authored-by: Florian Bernd <[email protected]>
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up! I have a high-level comment on the Access
model -- we want a new SearchAccess
model there, instead of re-using RemoteIndicesPrivileges
since those are subtly different (see my inline comment).
specification/security/create_cross_cluster_api_key/CreateCrossClusterApiKeyRequest.ts
Outdated
Show resolved
Hide resolved
/** | ||
* A list of indices permission entries for cross-cluster search. | ||
*/ | ||
search?: RemoteIndicesPrivileges[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a separate model (SearchAccess
) instead of RemoteIndicesPrivileges
since there are subtle differences:
SearchAccess
does not take a list of privilegesSearchAccess
does not take a list of remote clusters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay! I've added a separate definition in ef524c3
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
The create and update cross cluster key APIs were not appearing in the OpenAPI output, so I've created an initial pass at the necessary files per https://github.com/elastic/elasticsearch-specification/blob/main/docs/add-new-api.md
The descriptions are copied from https://www.elastic.co/guide/en/elasticsearch/reference/master/security-api-update-cross-cluster-api-key.html and