Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenAPI] Edits the autoscaling APIs #3081

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[OpenAPI] Edits the autoscaling APIs #3081

wants to merge 3 commits into from

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Oct 25, 2024

This PR edits the text to align with https://www.elastic.co/guide/en/elasticsearch/reference/master/autoscaling-apis.html.
It also changes the examples from .json to .yaml files and adds them to the overlays.

Review notes

Since the openAPI document is too big for previews and not hooked into buildkite previews yet, if reviewers are wanting to review the strings, they all appear in the output/openapi/elasticsearch-openapi.json file.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
autoscaling.delete_autoscaling_policy Missing test Missing test
autoscaling.get_autoscaling_capacity Missing test Missing test
autoscaling.get_autoscaling_policy Missing test Missing test
autoscaling.put_autoscaling_policy Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl marked this pull request as ready for review October 25, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant