-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logsdb telemetry #115994
base: main
Are you sure you want to change the base?
Add logsdb telemetry #115994
Conversation
Documentation preview: |
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Hi @dnhatn, I've created a changelog YAML for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I think we also need to update the mapping the telemetry repo. Similar to this elastic/telemetry#3415
} | ||
|
||
@Override | ||
protected void masterOperation( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this is the best place for this, but can we maybe in a follow up also track the number of indices without index mode that use synthetic source, the number of tsdb indices and how many of those tsdb indices use synthetic source? If you think this is a good idea. Maybe we should in this change rename the indices_count
and indices_with_synthetic_source
fields in the response to be something like logsdb_index_count
, logsdb_with_synthetic_source_index_count
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I considered this as well, but these fields don't seem to fit within logsdb. I think we'll need to add two separate usages: one for time_series and another for source_mode. I’ll add them in follow-up PRs.
{
"logsdb": {
"enabled": true,
"available": true,
"indices_count": 1,
"indices_with_synthetic_source": 1
}
}
ActionListener<XPackUsageFeatureResponse> listener | ||
) { | ||
int numIndices = 0; | ||
int numSyntheticSources = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe rename to numLogsdbIndices
and numLogsdbIndicesWithSynthticSource
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed 5dc58e6
This PR adds telemetry for logsdb. However, this change only tracks the count of indices using logsdb and those that use synthetic source. Additional stats, such as shard, indexing, and search stats, will be added in a follow-up, as they require reaching out to data nodes.