Skip to content

Commit

Permalink
add accessibility text
Browse files Browse the repository at this point in the history
  • Loading branch information
@rbrtj
rbrtj committed Oct 21, 2024
1 parent 0677ba2 commit 08cc76f
Show file tree
Hide file tree
Showing 6 changed files with 173 additions and 12 deletions.
120 changes: 108 additions & 12 deletions packages/eui/src/components/filter_group/__snapshots__/filter_button.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,15 @@ exports[`EuiFilterButton does not render a badge or count if numFilters is not p
>
<span
class="euiFilterButton__text emotion-euiFilterButton__text"
/>
data-text="select"
title="select"
>
<span
class="emotion-euiScreenReaderOnly"
>
select
</span>
</span>
</span>
</button>
`;
Expand All @@ -27,7 +35,15 @@ exports[`EuiFilterButton props badgeColor renders 1`] = `
>
<span
class="euiFilterButton__text emotion-euiFilterButton__text"
/>
data-text="select"
title="select"
>
<span
class="emotion-euiScreenReaderOnly"
>
select
</span>
</span>
</span>
</button>
`;
Expand All @@ -42,7 +58,15 @@ exports[`EuiFilterButton props grow can be turned off 1`] = `
>
<span
class="euiFilterButton__text emotion-euiFilterButton__text"
/>
data-text="select"
title="select"
>
<span
class="emotion-euiScreenReaderOnly"
>
select
</span>
</span>
</span>
</button>
`;
Expand All @@ -57,7 +81,15 @@ exports[`EuiFilterButton props iconType and iconSide renders 1`] = `
>
<span
class="euiFilterButton__text emotion-euiFilterButton__text"
/>
data-text="select"
title="select"
>
<span
class="emotion-euiScreenReaderOnly"
>
select
</span>
</span>
<span
color="inherit"
data-euiicon-type="user"
Expand All @@ -77,7 +109,15 @@ exports[`EuiFilterButton props isDisabled renders 1`] = `
>
<span
class="euiFilterButton__text emotion-euiFilterButton__text"
/>
data-text="select"
title="select"
>
<span
class="emotion-euiScreenReaderOnly"
>
select
</span>
</span>
</span>
</button>
`;
Expand All @@ -92,7 +132,15 @@ exports[`EuiFilterButton props isSelected renders 1`] = `
>
<span
class="euiFilterButton__text emotion-euiFilterButton__text"
/>
data-text="select"
title="select"
>
<span
class="emotion-euiScreenReaderOnly"
>
select
</span>
</span>
</span>
</button>
`;
Expand All @@ -107,7 +155,15 @@ exports[`EuiFilterButton props numActiveFilters and hasActiveFilters renders 1`]
>
<span
class="euiFilterButton__text euiFilterButton__text-hasNotification emotion-euiFilterButton__text-hasNotification"
/>
data-text="select"
title="select"
>
<span
class="emotion-euiScreenReaderOnly"
>
select
</span>
</span>
<span
aria-label="5 active filters"
class="euiNotificationBadge euiFilterButton__notification emotion-euiNotificationBadge-s-accent-euiFilterButton__notification-badgeContent"
Expand All @@ -129,7 +185,15 @@ exports[`EuiFilterButton props numFilters renders 1`] = `
>
<span
class="euiFilterButton__text euiFilterButton__text-hasNotification emotion-euiFilterButton__text-hasNotification"
/>
data-text="select"
title="select"
>
<span
class="emotion-euiScreenReaderOnly"
>
select
</span>
</span>
<span
aria-label="5 available filters"
class="euiNotificationBadge euiFilterButton__notification emotion-euiNotificationBadge-s-subdued-euiFilterButton__notification-badgeContent"
Expand All @@ -151,7 +215,15 @@ exports[`EuiFilterButton props type renders 1`] = `
>
<span
class="euiFilterButton__text emotion-euiFilterButton__text"
/>
data-text="select"
title="select"
>
<span
class="emotion-euiScreenReaderOnly"
>
select
</span>
</span>
</span>
</button>
`;
Expand All @@ -166,7 +238,15 @@ exports[`EuiFilterButton props withNext renders 1`] = `
>
<span
class="euiFilterButton__text emotion-euiFilterButton__text"
/>
data-text="select"
title="select"
>
<span
class="emotion-euiScreenReaderOnly"
>
select
</span>
</span>
</span>
</button>
`;
Expand All @@ -183,7 +263,15 @@ exports[`EuiFilterButton renders 1`] = `
>
<span
class="euiFilterButton__text emotion-euiFilterButton__text"
/>
data-text="select"
title="select"
>
<span
class="emotion-euiScreenReaderOnly"
>
select
</span>
</span>
</span>
</button>
`;
Expand All @@ -200,7 +288,15 @@ exports[`EuiFilterButton renders zero properly 1`] = `
>
<span
class="euiFilterButton__text euiFilterButton__text-hasNotification emotion-euiFilterButton__text-hasNotification"
/>
data-text="select"
title="select"
>
<span
class="emotion-euiScreenReaderOnly"
>
select
</span>
</span>
<span
aria-label="0 available filters"
class="euiNotificationBadge euiFilterButton__notification emotion-euiNotificationBadge-s-subdued-euiFilterButton__notification-badgeContent"
Expand Down
10 changes: 10 additions & 0 deletions packages/eui/src/components/search_bar/__snapshots__/search_bar.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,11 @@ exports[`SearchBar render - provided query, filters 1`] = `
title="Open"
>
Open
<span
class="emotion-euiScreenReaderOnly"
>
select
</span>
</span>
</span>
</button>
Expand All @@ -172,6 +177,11 @@ exports[`SearchBar render - provided query, filters 1`] = `
title="Tag"
>
Tag
<span
class="emotion-euiScreenReaderOnly"
>
select
</span>
</span>
<span
color="inherit"
Expand Down
10 changes: 10 additions & 0 deletions packages/eui/src/components/search_bar/__snapshots__/search_filters.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ exports[`EuiSearchBarFilters render - with filters 1`] = `
title="Open"
>
Open
<span
class="emotion-euiScreenReaderOnly"
>
select
</span>
</span>
</span>
</button>
Expand All @@ -43,6 +48,11 @@ exports[`EuiSearchBarFilters render - with filters 1`] = `
title="Tag"
>
Tag
<span
class="emotion-euiScreenReaderOnly"
>
select
</span>
</span>
<span
color="inherit"
Expand Down
20 changes: 20 additions & 0 deletions ...i/src/components/search_bar/filters/__snapshots__/field_value_toggle_filter.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ exports[`FieldValueToggleFilter render - active 1`] = `
title="Kibana"
>
Kibana
<span
class="emotion-euiScreenReaderOnly"
>
select
</span>
</span>
</span>
</button>
Expand All @@ -35,6 +40,11 @@ exports[`FieldValueToggleFilter render - active negated - custom negated name 1`
title="Others"
>
Others
<span
class="emotion-euiScreenReaderOnly"
>
select
</span>
</span>
</span>
</button>
Expand All @@ -55,6 +65,11 @@ exports[`FieldValueToggleFilter render - active negated 1`] = `
title="Not Kibana"
>
Not Kibana
<span
class="emotion-euiScreenReaderOnly"
>
select
</span>
</span>
</span>
</button>
Expand All @@ -75,6 +90,11 @@ exports[`FieldValueToggleFilter renders 1`] = `
title="Kibana"
>
Kibana
<span
class="emotion-euiScreenReaderOnly"
>
select
</span>
</span>
</span>
</button>
Expand Down
20 changes: 20 additions & 0 deletions ...components/search_bar/filters/__snapshots__/field_value_toggle_group_filter.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ exports[`TermToggleGroupFilter render - active 1`] = `
title="Kibana"
>
Kibana
<span
class="emotion-euiScreenReaderOnly"
>
select
</span>
</span>
</span>
</button>
Expand All @@ -35,6 +40,11 @@ exports[`TermToggleGroupFilter render - active negated - custom negated name 1`]
title="-Kibana"
>
-Kibana
<span
class="emotion-euiScreenReaderOnly"
>
select
</span>
</span>
</span>
</button>
Expand All @@ -55,6 +65,11 @@ exports[`TermToggleGroupFilter render - active negated 1`] = `
title="Not Kibana"
>
Not Kibana
<span
class="emotion-euiScreenReaderOnly"
>
select
</span>
</span>
</span>
</button>
Expand All @@ -75,6 +90,11 @@ exports[`TermToggleGroupFilter renders 1`] = `
title="Kibana"
>
Kibana
<span
class="emotion-euiScreenReaderOnly"
>
select
</span>
</span>
</span>
</button>
Expand Down
5 changes: 5 additions & 0 deletions packages/eui/src/components/search_bar/filters/__snapshots__/is_filter.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ exports[`IsFilter render 1`] = `
title="Open"
>
Open
<span
class="emotion-euiScreenReaderOnly"
>
select
</span>
</span>
</span>
</button>
Expand Down

0 comments on commit 08cc76f

Please sign in to comment.