Fix release script #7224
Merged
Fix release script #7224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
commented
Sep 25, 2023
| @@ -79,7 +79,7 @@ if (args.dry_run) { | |||
|
|
|||
| if (args.steps.indexOf('tag') > -1) { | |||
| // push the version commit & tag to upstream | |||
| execSync('git push upstream --tags', execOptions); | |||
| execSync('git push upstream --follow-tags', execOptions); | |||
There was a problem hiding this comment.
Docs: https://git-scm.com/docs/git-push#Documentation/git-push.txt---follow-tags
Essentially this should push all main commits to upstream, and also push the tag created from the previous npm version step as well
|
Preview staging links for this PR:
|
💚 Build Succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤦 I totally forgot in #7213 when I removed the
sync-docsstep that that step was doing the final push of all release commits. We need to re-add the push step somewhere, and I figured bogarting/using our existing push step for tags made the most sense