Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Convert all Elastic Charts docs pages to Typescript #7277

Merged
merged 19 commits into from
Oct 12, 2023
Merged

[Docs] Convert all Elastic Charts docs pages to Typescript #7277

merged 19 commits into from
Oct 12, 2023

Commits on Oct 10, 2023

  1. Convert shared files to TSX 

    - convert `PropTypes` to TS types

- Inline events to avoid having to type them explicitly
    @cee-chen
    cee-chen committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    865c037 View commit details
    Browse the repository at this point in the history

  2. Add missing groupByRollup param types

    @cee-chen
    cee-chen committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    be42a9b View commit details
    Browse the repository at this point in the history

  3. Fix showGridLines type 

    - convert to new API
    @cee-chen
    cee-chen committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    5364a3e View commit details
    Browse the repository at this point in the history

  4. Fix/convert other out of date prop APIs

    @cee-chen
    cee-chen committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    938a2eb View commit details
    Browse the repository at this point in the history

  5. Add missing id/misc props

    @cee-chen
    cee-chen committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    786b56a View commit details
    Browse the repository at this point in the history

  6. Remove props that shouldn't be there 

    - some where moved to theme settings instead, others just shouldn't have been there at all in the first place?
    @cee-chen
    cee-chen committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    5574809 View commit details
    Browse the repository at this point in the history

  7. Fix layers.shape.fillColor types

    @cee-chen
    cee-chen committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    d02aaa9 View commit details
    Browse the repository at this point in the history

  8. Fix ChartTypeCard props/types 

    - mixed logic is a bit of a headache try to simplify it via a conditional generic
    @cee-chen
    cee-chen committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    90dd645 View commit details
    Browse the repository at this point in the history

  9. Fix MultiChartCard props/types 

    - moving onChange callback to inline removes the need for typing the params explicitly
    @cee-chen
    cee-chen committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    3855d3f View commit details
    Browse the repository at this point in the history

  10. Fix more onChange types by moving them inline 

    - which removes the need to type the params explicitly
    @cee-chen
    cee-chen committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    fdbb82b View commit details
    Browse the repository at this point in the history

  11. ChartCard props/types fixes 

    - remove unused text/title props

- make `description` correctly conditional, and add more spacing to the affected card to make up for it
    @cee-chen
    cee-chen committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    2163137 View commit details
    Browse the repository at this point in the history

  12. Fix theme context to use typed hook

    @cee-chen
    cee-chen committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    7e44a7b View commit details
    Browse the repository at this point in the history

  13. Fix more fn param types

    @cee-chen
    cee-chen committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    fc22d2e View commit details
    Browse the repository at this point in the history

  14. Fix more misc var type definitions

    @cee-chen
    cee-chen committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    a811de6 View commit details
    Browse the repository at this point in the history

  15. Clean up palette obj iteration types 

    - including obj iteration microperf improvements
    @cee-chen
    cee-chen committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    f470392 View commit details
    Browse the repository at this point in the history

  16. Convert all Demo JS tabs to TSX

    @cee-chen
    cee-chen committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    82f6547 View commit details
    Browse the repository at this point in the history

  17. Remove React 18 @ts-ignores 

    - charts lib appears to work now with react 18
    @cee-chen
    cee-chen committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    dfa2a69 View commit details
    Browse the repository at this point in the history

  18. [misc] Fix DOM nesting error

    @cee-chen
    cee-chen committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    c99b5e3 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. fix: minor changes in api corrections

    @nickofthyme
    nickofthyme committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    9c1c992 View commit details
    Browse the repository at this point in the history