Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiFieldNumber] Fix native validity state when controlled value changes #7291

Merged
merged 7 commits into from
Oct 26, 2023
Merged

[EuiFieldNumber] Fix native validity state when controlled value changes #7291

merged 7 commits into from
Oct 26, 2023

Commits on Oct 26, 2023

  1. Add E2E test demonstrating the problem/testing the solution

    @cee-chen
    cee-chen committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    59d9927 View commit details
    Browse the repository at this point in the history

  2. Call checkNativeValidity on passed value change 

    - requires setting up an internal input ref to use and combining with the consumer `inputRef`
    @cee-chen
    cee-chen committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    5adce93 View commit details
    Browse the repository at this point in the history

  3. [misc] Add controlled onChange regression test

    @cee-chen
    cee-chen committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    c81f2d8 View commit details
    Browse the repository at this point in the history

  4. changelog

    @cee-chen
    cee-chen committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    8aff254 View commit details
    Browse the repository at this point in the history

  5. Add storybook for manual QA

    @cee-chen
    cee-chen committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    17ee2a7 View commit details
    Browse the repository at this point in the history

  6. Add more fixes for invalid states not updating as expected 

    + remove `onBlur` logic - the useEffect now handles that on mount, and blur behavior should no longer be necessary
    @cee-chen
    cee-chen committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    cd3a9e2 View commit details
    Browse the repository at this point in the history

  7. jsdom workaround 

    - NOTE: EuiDualRange snapshots will just be slightly incorrect until we're on jsdom 15+ 🤷
    @cee-chen
    cee-chen committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    e588aa3 View commit details
    Browse the repository at this point in the history