Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates capitalization guidelines in Writing doc #7300

Merged
merged 6 commits into from
Oct 23, 2023
Merged

Updates capitalization guidelines in Writing doc #7300

merged 6 commits into from
Oct 23, 2023

Conversation

gchaps
Copy link
Contributor

@gchaps gchaps commented Oct 19, 2023 •
edited
Loading

Summary

This PR updates the capitalization guidelines. It addresses the capitalization issues discussed in this issue.

Screenshot 2023-10-18 at 10 42 51 AM Screenshot 2023-10-18 at 10 43 03 AM

@gchaps gchaps requested a review from a team as a code owner October 19, 2023 16:18
@cee-chen cee-chen added skip-changelog documentation Issues or PRs that only affect documentation - will not need changelog entries labels Oct 19, 2023
@cee-chen
Copy link
Member

Changes look great aside from the above nits! LMK if you'd prefer that I just auto-commit the suggestions and merge the PR after @gchaps

lcawl
lcawl reviewed Oct 23, 2023
View reviewed changes
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a lot easier to follow. Thanks for the clear and simple info!

@cee-chen cee-chen enabled auto-merge (squash) October 23, 2023 21:02
@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@cee-chen cee-chen merged commit 0f85892 into elastic:main Oct 23, 2023
7 checks passed
@gchaps gchaps deleted the docs/capitalization-guidelines branch October 27, 2023 15:42
@florent-leborgne florent-leborgne mentioned this pull request Oct 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcawl lcawl lcawl left review comments

@cee-chen cee-chen cee-chen approved these changes

Assignees
No one assigned
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gchaps @cee-chen @kibanamachine @elasticmachine @lcawl