-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add header badge for PR staging instances #7347
Conversation
b588ccf
to
507c0f7
Compare
+ DRY out EUI github URL
507c0f7
to
b4a1fa0
Compare
@elastic/eui-team let me know what you think! Personally I think this is pretty useful (especially for demos or external links to a PR staging server where people may want to go to the original PR for more context). Also looking for feedback on the badge color, is |
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Wow, this is cool @cee-chen! I love the Staging
link back to the PR, excellent touch.
Thanks Trevor!! Going to go ahead and merge this so I can see it in action in a couple new/open PRs. But as always, if anyone has any feedback after the fact, just leave a comment - I'm always happy to open a follow-up PR or continue to tweak! |
Summary
It occurred to me on a whim today that our PR staging instances (e.g. https://eui.elastic.co/pr_7347) should likely show some affordance for what they are (a staging server) rather than using the plain old version switcher (#7298). Here's my proposal for the different environments:
Staging (link goes back to the originating GitHub PR)
Local (no link/switcher)
Production (version switcher)
QA
Check it out! https://eui.elastic.co/pr_7347/#/
General checklist
N/A, docs only