-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix Colors > Contrast docs page #7506
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
added
documentation
Issues or PRs that only affect documentation - will not need changelog entries
skip-changelog
labels
Feb 2, 2024
cee-chen
force-pushed
the
docs/list-group-item
branch
from
February 2, 2024 19:49
a574c48
to
eb644ae
Compare
- caused by `.map`/components that returns empty null/undefined
cee-chen
changed the title
[docs] Contrast page: fix
[docs] Fix Colors > contrast docs page
Feb 2, 2024
EuiListGroupItem
default button color overriding parent style
cee-chen
changed the title
[docs] Fix Colors > contrast docs page
[docs] Fix Colors > Contrast docs page
Feb 2, 2024
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
tkajtoch
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Issues or PRs that only affect documentation - will not need changelog entries
skip-changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #7500
The text color broke in #7298, as part of this changelog item:
The contrast page was passing
style
to EuiListGroupItem and relying it to go onto the<button>
element instead of the<li>
. This broken the inherited color styling of the various button(s).While here I also noticed a whole lot of other things going wrong with this page (😅) and pushed up several fixes - see the commit history.
QA
General checklist
- [ ] Checked in mobile- [ ] Checked for accessibility including keyboard-only and screenreader modes