Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiPageHeaderContent] Improve responsiveness #8044

Merged
merged 10 commits into from
Sep 26, 2024
Merged

[EuiPageHeaderContent] Improve responsiveness #8044

merged 10 commits into from
Sep 26, 2024

Commits on Sep 25, 2024

  1. [EuiPageHeaderContent] Various cleanup 

    - Improve/update prop docs

- Improve storybook controls to match actual defaults/options

- add example `children`

- (bonus) memoize styles
    @cee-chen
    cee-chen committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    870beb3 View commit details
    Browse the repository at this point in the history

  2. Add story for legacy childrenOnly UI 

    - just to make sure I don't regress anything in this PR
    @cee-chen
    cee-chen committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c7ec7dc View commit details
    Browse the repository at this point in the history

  3. Add VRT illustrating problem being fixed

    @cee-chen
    cee-chen committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a1c3b5f View commit details
    Browse the repository at this point in the history

  4. Move tabs outside of left side on desktop and into true bottom 

    - but keep `children` in left side
    @cee-chen
    cee-chen committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    1014609 View commit details
    Browse the repository at this point in the history

  5. Add VRT illustrating problem being fixed

    @cee-chen
    cee-chen committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    cc5f1d7 View commit details
    Browse the repository at this point in the history

  6. Improve responsive wrapping at smaller container sizes 

    + DOM cleanup - remove unnecessary `EuiFlexItem` around `rightSideItems` since we're writing custom flex CSS in any case
    @cee-chen
    cee-chen committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    eb70ea7 View commit details
    Browse the repository at this point in the history

  7. [cleanup] Remove unnecessary return ternary 

    - now possible since we've simplified our DOM

- no idea why `alignItems === 'top'` needs to be its own condition, it's not doing anything special. remove it since this appears to be defunct code
    @cee-chen
    cee-chen committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    7ac93fc View commit details
    Browse the repository at this point in the history

  8. Update downstream EuiPageTemplate/EuiPageHeader VRT + snapshots 

    - slight changes are due to font/typography IIRC, this should mostly show that nothing meaningfully broke for major use cases
    @cee-chen
    cee-chen committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    248139a View commit details
    Browse the repository at this point in the history

  9. changelog

    @cee-chen
    cee-chen committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    3a96c32 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. [PR feedback] Spelling 2: Spelling Harder

    @cee-chen
    cee-chen committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    4384aa4 View commit details
    Browse the repository at this point in the history