[A11y] [SearchBar] [Filters] Improve accessibility of the Filters toggle button #8091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexwizp Any chance we could get you to test-drive this on https://eui.elastic.co/pr_8091/storybook/?path=/story/forms-euisearchbar-euisearchbar--playground and get your a11y expertise on the changes before we dive into code review? |
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
cc @rbrtj |
|
Hey @rbrtj. Thanks for the contribution. Just FYI that this is on our radar we just haven't had a chance to review and test it yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to:
#8088
Added additional text inside the filter button so that the screen reader reads
<filter label> Selectinstead of just<filter label>. Updated snapshots to ensure all tests pass.