-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add latest components MDX content #8095
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed some code examples that didn't work:
- datepicker: https://eui.elastic.co/pr_8095/new-docs/docs/forms/date-picker/
- filter group: https://eui.elastic.co/pr_8095/new-docs/docs/forms/filter-group/#filter-buttons
- form controls: https://eui.elastic.co/pr_8095/new-docs/docs/forms/form-controls
- selectable: https://eui.elastic.co/pr_8095/new-docs/docs/forms/selectable/#flexbox
- checkbox group: https://eui.elastic.co/pr_8095/new-docs/docs/forms/selection-controls/#checkbox-group
- radio group: https://eui.elastic.co/pr_8095/new-docs/docs/forms/selection-controls/#radio-group
- switch: https://eui.elastic.co/pr_8095/new-docs/docs/forms/selection-controls/#switch
- super select states: https://eui.elastic.co/pr_8095/new-docs/docs/forms/super-select/#states
- in memory tables and tables: https://eui.elastic.co/pr_8095/new-docs/docs/tabular-content/in-memory-tables/
- markdownFormat error: https://eui.elastic.co/pr_8095/new-docs/docs/editors-syntax/markdown-format/#kitchen-sink
- markdown plugins error: https://eui.elastic.co/pr_8095/new-docs/docs/editors-syntax/markdown-plugins/#putting-it-all-together-a-simple-chart-plugin
- a11y features: https://eui.elastic.co/pr_8095/new-docs/docs/editors-syntax/markdown-format/#kitchen-sink
- creating charts: https://eui.elastic.co/pr_8095/new-docs/docs/elastic-charts/creating-charts/#theming-via-eui
- metric chart: https://eui.elastic.co/pr_8095/new-docs/docs/elastic-charts/metric-chart/#single-value
- part to whole comparisons: https://eui.elastic.co/pr_8095/new-docs/docs/elastic-charts/part-to-whole-comparisons/
- sizing: https://eui.elastic.co/pr_8095/new-docs/docs/elastic-charts/sizing/#sparklines
And a couple additional pages that look like something is not properly parsed:
}; | ||
}; | ||
|
||
const ExampleDescription = ({ children }: PropsWithChildren) => children; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗒️ We discussed the purpose of these shell components, and agreed to add a comment for context.
|
||
``` | ||
|
||
## Column widths |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗒️ As disussed, we added an additional section in the old docs for draggable columns that's missing here still.
|
||
import Link from '@docusaurus/Link'; | ||
|
||
# Header |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this is expected but the header component here is global and to me it wasn't intuitive since the example container is empty 🤔
@mgadewoll all things from your list should be fixed now. Most of them were fixed by simply exposing |
@tkajtoch I still noticed some issues.
|
@tkajtoch I missed another broken code example before:
|
@tkajtoch Is it expected that the "Utilities" section is missing in the new docs? 🤔 |
@tkajtoch This is unrelated to the content changes, but I figured I pin it here anyway: I think we might want to reduce the content max-width, at least for the problematic viewport range. |
9a2b5b2
to
f1c78d9
Compare
f1c78d9
to
e4ef96e
Compare
Preview staging links for this PR:
|
💚 Build Succeeded
History
cc @tkajtoch |
The remaining content fixes and improvements will be added as separate PRs. We discussed it's best to merge this PR as-is and continue working in more focused branches |
Summary
This PR is part of https://github.com/elastic/eui-private/issues/137.
This adds the latest components docs files and renames the
02_components
directory tocomponents
for easier reordering if needed. All of the content comes from https://eui.elastic.co and doesn't need to be proofread as part of the review process as it was already previously reviewed.I recommend reviewing commit by commit. This branch also includes a couple of code changes, specifically updating the list styles to be compatible with EUI styling and adding a utility
Example
component used in the theming and utilities docs sections.QA