[Fleet] Fix docker publish step in buildkite #2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
commented
Jul 24, 2023
| @@ -105,6 +105,8 @@ steps: | |||
| env: | |||
| SERVICE_COMMIT_HASH: ${BUILDKITE_COMMIT:0:12} | |||
| REMOTE_SERVICE_CONFIG: https://raw.githubusercontent.com/elastic/serverless-gitops/main/gen/gpctl/fleet/config.yaml | |||
| depends_on: | |||
| - step: "publish" | |||
There was a problem hiding this comment.
I added a dependency here so we do not update tags with non valid image
|
@michel-laterman should we replace the |
|
@nchaulet I just fixed this by adding buildkite as a required step and removed the jenkins one. |
mergify bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
(cherry picked from commit 5cce568) # Conflicts: # .buildkite/pipeline.yml
jlind23
added a commit
that referenced
this pull request
Jul 26, 2023
…2818) * [Fleet] Fix docker publish step in buildkite (#2815) (cherry picked from commit 5cce568) # Conflicts: # .buildkite/pipeline.yml * Update pipeline.yml Fix conflicts --------- Co-authored-by: Nicolas Chaulet <[email protected]> Co-authored-by: Julien Lind <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix docker publish step in buildkite
The if condition to build the docker image was not met
It seems according to buildkite doc that
BUILDKITE_PULL_REQUESTshould be false if it's not a pull request and not an empty string