Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add path to release-manager script #2837

Merged
merged 3 commits into from
Jul 27, 2023
Merged

add path to release-manager script #2837

merged 3 commits into from
Jul 27, 2023

Conversation

sharbuz
Copy link
Contributor

@sharbuz sharbuz commented Jul 27, 2023

What is the problem this PR solves?

fix the issue: https://buildkite.com/elastic/fleet-server-package-mbp/builds/240#0189966d-f773-4479-be35-7913b0e5f9db

How does this PR solve the problem?

add cd ${WORKSPACE} to the release-manager script

Related issues

#2517

@sharbuz sharbuz added the ci CI related tasks label Jul 27, 2023
@sharbuz sharbuz requested review from mrodm and jlind23 July 27, 2023 08:46
@sharbuz sharbuz self-assigned this Jul 27, 2023
@sharbuz sharbuz requested a review from a team as a code owner July 27, 2023 08:46
Comment on lines 24 to 25
chmod -R a+r "${WORKSPACE}"/"$FOLDER"/*
chmod -R a+w "${WORKSPACE}"/"$FOLDER"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be the same if
FOLDER would get that value from dra_release.sh ?
Suggestion added in the other comment

To keep the script as it was (if possible)

.buildkite/scripts/dra_release.sh Show resolved Hide resolved
@sharbuz
Copy link
Contributor Author

sharbuz commented Jul 27, 2023

I added the cd ${WORKSPACE} command to avoid possible issues in the next lines.

@sharbuz sharbuz enabled auto-merge (squash) July 27, 2023 09:17
@sharbuz
Copy link
Contributor Author

sharbuz commented Jul 27, 2023

/package

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 27, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-27T09:18:04.992+0000

  • Duration: 34 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 751
Skipped 1
Total 752

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@sharbuz sharbuz merged commit 8dd20c8 into elastic:main Jul 27, 2023
6 checks passed
@sharbuz sharbuz deleted the fix-path branch July 27, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants