Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source common.sh in release-manager.sh #2841

Closed
wants to merge 1 commit into from

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented Jul 27, 2023

What is the problem this PR solves?

// Please do not just reference an issue. Explain WHAT the problem this PR solves here.

+ retry 3 docker pull --quiet docker.elastic.co/infra/release-manager:latest
./.buildkite/scripts/release-manager.sh: line 30: retry: command not found
+ echo 'Error pulling docker.elastic.co/infra/release-manager:latest Docker image, we continue'
Error pulling docker.elastic.co/infra/release-manager:latest Docker image, we continue

How does this PR solve the problem?

// Explain HOW you solved the problem in your code. It is possible that during PR reviews this changes and then this section should be updated.

How to test this PR locally

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 27, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-27T14:18:29.092+0000

  • Duration: 36 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 751
Skipped 1
Total 752

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@mrodm mrodm force-pushed the fix_retry_command_release_manager branch from dfcfa73 to e094b83 Compare July 27, 2023 14:18
@mergify
Copy link
Contributor

mergify bot commented Jul 27, 2023

This pull request is now in conflicts. Could you fix it @mrodm? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b fix_retry_command_release_manager upstream/fix_retry_command_release_manager
git merge upstream/main
git push upstream fix_retry_command_release_manager

@mrodm mrodm closed this Jul 27, 2023
@mrodm mrodm deleted the fix_retry_command_release_manager branch July 27, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants