Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleting secret_references from computed agent policy #2876

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

juliaElastic
Copy link
Contributor

@juliaElastic juliaElastic commented Aug 15, 2023

What is the problem this PR solves?

Cleanup

How does this PR solve the problem?

Remove secret_references from the computed agent policy being sent out to agents.

How to test this PR locally

Add an integration with secrets, enroll an agent, check in agent diagnostics that the agent policy doesn't contain secret_references

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues

Related to elastic/kibana#154715

@juliaElastic juliaElastic self-assigned this Aug 15, 2023
@juliaElastic juliaElastic requested a review from a team as a code owner August 15, 2023 06:58
@elasticmachine
Copy link
Contributor

elasticmachine commented Aug 15, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-15T09:33:45.729+0000

  • Duration: 39 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 752
Skipped 1
Total 753

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@juliaElastic juliaElastic changed the title deleting secret_references from agent policy deleting secret_references from computed agent policy Aug 15, 2023
@juliaElastic juliaElastic merged commit 7bca49b into elastic:main Aug 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants