Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix branch version number #2888

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Fix branch version number #2888

merged 1 commit into from
Aug 17, 2023

Conversation

pierrehilbert
Copy link
Contributor

What is the problem this PR solves?

Fix human error causing wrong version numbers.
// Please do not just reference an issue. Explain WHAT the problem this PR solves here.

How does this PR solve the problem?

// Explain HOW you solved the problem in your code. It is possible that during PR reviews this changes and then this section should be updated.

How to test this PR locally

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues

@pierrehilbert pierrehilbert added the backport-skip Skip notification from the automated backport with mergify label Aug 17, 2023
@pierrehilbert pierrehilbert requested a review from a team as a code owner August 17, 2023 06:56
@jlind23 jlind23 enabled auto-merge (squash) August 17, 2023 06:58
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-17T06:56:21.796+0000

  • Duration: 36 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 753
Skipped 1
Total 754

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@jlind23 jlind23 merged commit 9697d54 into 8.10 Aug 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants