[Fleet] Improve error handling for invalid base64 token #3056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpollich
approved these changes
Oct 24, 2023
|
SonarQube Quality Gate
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
(cherry picked from commit 407dc9c)
mergify bot
added a commit
that referenced
this pull request
Oct 25, 2023
(cherry picked from commit 407dc9c) Co-authored-by: Nicolas Chaulet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve #3046
Improve error handling when enrollemnt token or api key during checkin is not a valid base64 token, and return a 400 instead of a 500.
This is covered by a new unit test