Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.11] bump golang version 1.20.10 #3099

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

leehinman
Copy link
Contributor

What is the problem this PR solves?

Bump golang version to 1.20.10

How does this PR solve the problem?

// Explain HOW you solved the problem in your code. It is possible that during PR reviews this changes and then this section should be updated.

How to test this PR locally

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues

@leehinman leehinman requested a review from a team as a code owner November 13, 2023 23:33
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 13, 2023

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-14T19:28:35.027+0000

  • Duration: 18 min 35 sec

Test stats 🧪

Test Results
Failed 0
Passed 837
Skipped 1
Total 838

Steps errors 1

Expand to view the steps failures

test
  • Took 2 min 19 sec . View more details here
  • Description: make test-e2e

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

juliaElastic
juliaElastic previously approved these changes Nov 14, 2023
@leehinman leehinman enabled auto-merge (squash) November 14, 2023 17:42
@leehinman
Copy link
Contributor Author

/test

@jlind23
Copy link
Contributor

jlind23 commented Nov 14, 2023

buildkite test this

Copy link
Contributor

@michel-laterman michel-laterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the go version reference in the linter as well

Copy link
Contributor

@michel-laterman michel-laterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jlind23
Copy link
Contributor

jlind23 commented Nov 15, 2023

buildkite test this

Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@leehinman leehinman merged commit d698b77 into elastic:8.11 Nov 15, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants