-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test collector plugin for Buildkite analytics #3927
Conversation
This pull request does not have a backport label. Could you fix it @rowlandgeoff? 🙏
|
|
Quality Gate passedIssues Measures |
if [[ "$BUILDKITE_PIPELINE_SLUG" == "fleet-server" ]]; then | ||
if [[ "$BUILDKITE_STEP_KEY" == "int-test" || "$BUILDKITE_STEP_KEY" == "e2e-test" ]]; then | ||
echo "--- Prepare BK test analytics token :vault:" | ||
BUILDKITE_ANALYTICS_TOKEN=$(vault kv get -field token kv/ci-shared/platform-ingest/buildkite_fleet_server_analytics_token) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no comment; we did in other repositories, but IMHO, it's not ideal either—except Beats, due to the nature of the pipelines.
The secret should be in a repository-scoped vault path rather than a shared vault path. This is a good idea because the secret makes sense only for this repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have repo-scoped vault paths that we use for CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure we do https://docs.elastic.dev/ci/using-secrets#using-repository-scoped-secrets
But we can move them afterwards.
Looks good to me, were you able to have a successful run on your PR already? |
@jlind23 Yes, had 2 successful runs on the PR before I switched it to only run on main. |
@rowlandgeoff Let's merge it then :-) |
Add the test collector plugin to enable Buildkite test analytics. Test results will be shown here after main branch pipeline runs: https://buildkite.com/organizations/elastic/analytics/suites/fleet-server
Closes https://github.com/elastic/ingest-dev/issues/3916