Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test collector plugin for Buildkite analytics #3927

Merged
merged 7 commits into from
Oct 15, 2024

Conversation

rowlandgeoff
Copy link
Contributor

@rowlandgeoff rowlandgeoff commented Sep 19, 2024

Add the test collector plugin to enable Buildkite test analytics. Test results will be shown here after main branch pipeline runs: https://buildkite.com/organizations/elastic/analytics/suites/fleet-server

Closes https://github.com/elastic/ingest-dev/issues/3916

Copy link
Contributor

mergify bot commented Sep 19, 2024

This pull request does not have a backport label. Could you fix it @rowlandgeoff? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Sep 19, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 19, 2024
@rowlandgeoff rowlandgeoff added backport-skip Skip notification from the automated backport with mergify and removed backport-8.x Automated backport to the 8.x branch with mergify labels Oct 15, 2024
@rowlandgeoff rowlandgeoff marked this pull request as ready for review October 15, 2024 03:22
@rowlandgeoff rowlandgeoff requested a review from a team as a code owner October 15, 2024 03:22
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Oct 15, 2024
if [[ "$BUILDKITE_PIPELINE_SLUG" == "fleet-server" ]]; then
if [[ "$BUILDKITE_STEP_KEY" == "int-test" || "$BUILDKITE_STEP_KEY" == "e2e-test" ]]; then
echo "--- Prepare BK test analytics token :vault:"
BUILDKITE_ANALYTICS_TOKEN=$(vault kv get -field token kv/ci-shared/platform-ingest/buildkite_fleet_server_analytics_token)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no comment; we did in other repositories, but IMHO, it's not ideal either—except Beats, due to the nature of the pipelines.

The secret should be in a repository-scoped vault path rather than a shared vault path. This is a good idea because the secret makes sense only for this repository.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have repo-scoped vault paths that we use for CI?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlind23
Copy link
Contributor

jlind23 commented Oct 15, 2024

Looks good to me, were you able to have a successful run on your PR already?

@rowlandgeoff
Copy link
Contributor Author

Looks good to me, were you able to have a successful run on your PR already?

@jlind23 Yes, had 2 successful runs on the PR before I switched it to only run on main.

@jlind23
Copy link
Contributor

jlind23 commented Oct 15, 2024

@rowlandgeoff Let's merge it then :-)

@rowlandgeoff rowlandgeoff merged commit fe5697b into main Oct 15, 2024
8 checks passed
@rowlandgeoff rowlandgeoff deleted the testCollectorPlugin branch October 15, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants