[8.x](backport #3991) Don't fail checkin if agent has upgrade details with no action #4034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
pierrehilbert
added
the
Team:Elastic-Agent-Control-Plane
pierrehilbert
approved these changes
Oct 23, 2024
kaanyalti
approved these changes
Oct 23, 2024
|
This pull request has not been merged yet. Could you please review and merge it @jillguyonnet? 🙏 |
|
buildkite test this |
|
@elastic/elastic-agent-control-plane Do you know what might be causing the e2e tests to fail? The error in the build is not very specific: Also, I opened the build for the original PR and I found that the e2e tests had not actually run but the build still succeeded: |
Don't fail checkin if agent has upgrade details with no action (cherry picked from commit 9dc43b0)
ycombinator
force-pushed
the
mergify/bp/8.x/pr-3991
branch
from
3642a53
to
143dc3e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
Relates https://github.com/elastic/ingest-dev/issues/4223
We're investigating an issue in a serverless project where Fleet Server keeps throwing 500 on agent checkin because the agent has upgrade details but the action id they refer to is not found.
How does this PR solve the problem?
Modify
Checkin.processUpgradeDetailsso that checkin does not fail in this scenario and log a warning instead.This is an automatic backport of pull request #3991 done by Mergify.