Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestAgentInstallSuite #4058

Closed
wants to merge 2 commits into from

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Oct 28, 2024

What is the problem this PR solves?

CI has been failing on the 8.x branch since #4013 was merged. It fails on TestAgentInstallSuite with the message: "unable to find package download". This PR attempts to figure out why this failure is happening (it's not happening on the main branch) and fix it.

How does this PR solve the problem?

// Explain HOW you solved the problem in your code. It is possible that during PR reviews this changes and then this section should be updated.

This PR hardcodes the value of ELASTICSEARCH_VERSION used by integration tests correctly for the 8.x branch. This value must be kept up to date by automation, which is currently not happening (see #4059).

@ycombinator
Copy link
Contributor Author

ycombinator commented Oct 29, 2024

Looks like the root cause is #4059. Testing that theory in this PR via c3d46b9.

Copy link

@ycombinator
Copy link
Contributor Author

ycombinator commented Oct 29, 2024

The test that's failing in CI now will be fixed in #4030. So we need both PRs to be merged for 8.x to go green again. I suggest we merge this PR first, then rebase #4030 on 8.x and merge it if CI is green on it.

@ycombinator ycombinator marked this pull request as ready for review October 29, 2024 05:07
@ycombinator ycombinator requested a review from a team as a code owner October 29, 2024 05:07
@ycombinator ycombinator added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Oct 29, 2024
@ycombinator
Copy link
Contributor Author

Closing in favor of #4020 now that #4059 is resolved, the https://github.com/elastic/fleet-server/actions/runs/11569972328 action was run, and #4020 has been updated by that action.

@ycombinator ycombinator deleted the fix-agent-install-test branch October 29, 2024 12:43
@ycombinator ycombinator added backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant