Remove dependency on github.com/docker/docker #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker is used to test in environments with different hostnames and domain names. This was done by interacting with the Docker API via a dependency on github.com/docker/docker. But this brings in a lot of dependency baggage. This change replaces docker API interaction with invocation of `docker run`. This results in a reduced dependency set for the module.
andrewkroh
force-pushed
the
break-docker-dep
branch
from
d814cd7
to
3cd064a
Compare
efd6
reviewed
Apr 5, 2024
Comment on lines
125
to
126
| cmd.Stdout = os.Stdout | ||
| cmd.Stderr = os.Stderr |
There was a problem hiding this comment.
Capture these in a buffer? Then they can be emitted in the t.Logf call.
There was a problem hiding this comment.
SGTM d518340. Here's the new output:
ubuntu@neat-chimpanzee:/go-sysinfo/providers/linux$ go test -run TestHost_FQDN -tags integration -v .
=== RUN TestHost_FQDN
=== RUN TestHost_FQDN/TestHost_FQDN_set_hostname+domainname
host_fqdn_integration_linux_test.go:84: Running docker container using ["run" "--rm" "-v" "/home/ubuntu/go:/go" "-v" "/go-sysinfo:/go-sysinfo" "-w=/go-sysinfo" "--hostname=hostname" "--domainname=some.domain" "golang:1.22.2" "go" "test" "-v" "-tags" "integration,docker" "-run" "^TestHost_FQDN_set$" "./providers/linux"]
host_fqdn_integration_linux_test.go:84: Container output:
=== RUN TestHost_FQDN_set
--- PASS: TestHost_FQDN_set (0.00s)
PASS
ok github.com/elastic/go-sysinfo/providers/linux 0.005s
host_fqdn_integration_linux_test.go:84: Exiting container
=== RUN TestHost_FQDN/TestHost_FQDN_set_hostname_only
host_fqdn_integration_linux_test.go:84: Running docker container using ["run" "--rm" "-v" "/home/ubuntu/go:/go" "-v" "/go-sysinfo:/go-sysinfo" "-w=/go-sysinfo" "--hostname=hostname.some.domain" "golang:1.22.2" "go" "test" "-v" "-tags" "integration,docker" "-run" "^TestHost_FQDN_set$" "./providers/linux"]
host_fqdn_integration_linux_test.go:84: Container output:
=== RUN TestHost_FQDN_set
--- PASS: TestHost_FQDN_set (0.00s)
PASS
ok github.com/elastic/go-sysinfo/providers/linux 0.006s
host_fqdn_integration_linux_test.go:84: Exiting container
=== RUN TestHost_FQDN/TestHost_FQDN_not_set
host_fqdn_integration_linux_test.go:84: Running docker container using ["run" "--rm" "-v" "/home/ubuntu/go:/go" "-v" "/go-sysinfo:/go-sysinfo" "-w=/go-sysinfo" "golang:1.22.2" "go" "test" "-v" "-count" "1" "-tags" "integration,docker" "-run" "^TestHost_FQDN_not_set$" "./providers/linux"]
host_fqdn_integration_linux_test.go:84: Container output:
=== RUN TestHost_FQDN_not_set
--- PASS: TestHost_FQDN_not_set (0.00s)
PASS
ok github.com/elastic/go-sysinfo/providers/linux 0.007s
host_fqdn_integration_linux_test.go:84: Exiting container
--- PASS: TestHost_FQDN (54.56s)
--- PASS: TestHost_FQDN/TestHost_FQDN_set_hostname+domainname (17.82s)
--- PASS: TestHost_FQDN/TestHost_FQDN_set_hostname_only (18.14s)
--- PASS: TestHost_FQDN/TestHost_FQDN_not_set (18.60s)
PASS
ok github.com/elastic/go-sysinfo/providers/linux 54.562s
efd6
approved these changes
Apr 5, 2024
This was referenced Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker is used to test in environments with different hostnames and domain names. This was done by interacting with the Docker API via a dependency on github.com/docker/docker. But this brings in a lot of dependency baggage.
This change replaces docker API interaction with invocation of
docker run. This results in a reduced dependency set for the module.I recommend to hide whitespace changes when viewing the diff.